Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarks #2498

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Fix benchmarks #2498

wants to merge 6 commits into from

Commits on Sep 25, 2023

  1. Require new Capabilities::BINDING_ARRAY for binding_array type. 

    Introduce a new `Capabilities::BINDING_ARRAY` flag, which enables use
of the Naga `TypeInner::BindingArray` type.

Adjust tests that exercise binding arrays to pass this flag.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bdbb8e5 View commit details
    Browse the repository at this point in the history

  2. Add Capabilities::ATOMIC_COMPARE_EXCHANGE_WEAK. 

    We haven't finished implementing WGSL's `atomicCompareExchangeWeak` on
all platforms (#1413). It's valuable to have some configuration of
validation that guarantees backends will succeed, and adding a
`Capabilities` bit that is included by default but can be turned off
accomplishes that.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ce8df06 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'binding-array-capability' into smudve

    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    24d03a4 View commit details
    Browse the repository at this point in the history

  4. For benchmarking backends, skip modules using unfinished features.

    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    eb9cb4c View commit details
    Browse the repository at this point in the history

  5. criterion benchmark: properly conditionalize GLSL parsing code.

    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    119af94 View commit details
    Browse the repository at this point in the history

  6. criterion benchmark: promise a modern MSL back end.

    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a245467 View commit details
    Browse the repository at this point in the history