-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen langchain peer requirements #97
Conversation
…sing memory string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0ff9aa0 in 8 seconds
More details
- Looked at
58
lines of code in2
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. src/langchain/utils.ts:25
- Draft comment:
Consider usingBoolean
instead ofx => !!x
for filtering non-null values for better readability.
const relevantFactStrings: string[] = memory.relevantFacts.map(({fact}) => fact).filter(Boolean) as string[];
- Reason this comment was not posted:
Confidence changes required:33%
The code incondenseZepMemoryIntoHumanMessage
can be optimized for readability and performance.
Workflow ID: wflow_FwaPySkMomTCAg4E
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 925ba9c in 9 seconds
More details
- Looked at
22
lines of code in1
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. package.json:43
- Draft comment:
Consider updating@langchain/openai
to use a version range similar tolangchain
for consistency. - Reason this comment was not posted:
Confidence changes required:50%
The versioning for@langchain/openai
indevDependencies
is inconsistent with the otherlangchain
packages. It should be updated to match the pattern used forlangchain
.
Workflow ID: wflow_YY6yroc4j9sLafuD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Loosen
langchain
peer dependencies and updatecondenseZepMemoryIntoHumanMessage
to userelevantFacts
.@langchain/core
to>=0.1.29 <0.4.0
andlangchain
to>=0.1.19 <0.4.0
inpackage.json
.@langchain/core
to^0.3.7
,@langchain/openai
to0.3.5
, andlangchain
to0.3.2
.condenseZepMemoryIntoHumanMessage
inutils.ts
to usememory.relevantFacts
instead ofmemory.facts
for constructingsystemPrompt
.This description was created by for 925ba9c. It will automatically update as commits are pushed.