Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen langchain peer requirements #97

Merged
merged 19 commits into from
Oct 4, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Oct 4, 2024

Important

Loosen langchain peer dependencies and update condenseZepMemoryIntoHumanMessage to use relevantFacts.

  • Dependencies:
    • Loosen peer dependencies for @langchain/core to >=0.1.29 <0.4.0 and langchain to >=0.1.19 <0.4.0 in package.json.
    • Update dev dependencies: @langchain/core to ^0.3.7, @langchain/openai to 0.3.5, and langchain to 0.3.2.
  • Functionality:
    • Modify condenseZepMemoryIntoHumanMessage in utils.ts to use memory.relevantFacts instead of memory.facts for constructing systemPrompt.

This description was created by Ellipsis for 925ba9c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0ff9aa0 in 8 seconds

More details
  • Looked at 58 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/langchain/utils.ts:25
  • Draft comment:
    Consider using Boolean instead of x => !!x for filtering non-null values for better readability.
const relevantFactStrings: string[] = memory.relevantFacts.map(({fact}) => fact).filter(Boolean) as string[];
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The code in condenseZepMemoryIntoHumanMessage can be optimized for readability and performance.

Workflow ID: wflow_FwaPySkMomTCAg4E


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 925ba9c in 9 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. package.json:43
  • Draft comment:
    Consider updating @langchain/openai to use a version range similar to langchain for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The versioning for @langchain/openai in devDependencies is inconsistent with the other langchain packages. It should be updated to match the pattern used for langchain.

Workflow ID: wflow_YY6yroc4j9sLafuD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 969e2e4 into main Oct 4, 2024
3 checks passed
@paul-paliychuk paul-paliychuk deleted the loosen-langchain-peer-requirements branch October 4, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant