Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdk release workflow #89

Merged
merged 13 commits into from
Sep 24, 2024
Merged

Fix sdk release workflow #89

merged 13 commits into from
Sep 24, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Sep 24, 2024

Important

Change npm publish workflows to trigger on release events and add branch-specific conditions.

  • Workflows:
    • Change trigger from push to release event in npm-publish-ce.yml and npm-publish-cloud.yml.
    • Add branch condition github.ref == 'refs/heads/community' in npm-publish-ce.yml and github.ref == 'refs/heads/cloud' in npm-publish-cloud.yml.

This description was created by Ellipsis for cbbc287. It will automatically update as commits are pushed.

@paul-paliychuk paul-paliychuk merged commit ea8c805 into main Sep 24, 2024
2 checks passed
@paul-paliychuk paul-paliychuk deleted the fix-sdk-release-workflow branch September 24, 2024 21:04
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to cbbc287 in 46 seconds

More details
  • Looked at 41 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/npm-publish-cloud.yml:11
  • Draft comment:
    The condition if: github.ref == 'refs/heads/cloud' is incorrect for a release event. It should check for a tag reference instead, such as if: startsWith(github.ref, 'refs/tags/').
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_omgL4oIZwHx7O9Ol


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

jobs:
build:
if: github.ref == 'refs/heads/community'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition if: github.ref == 'refs/heads/community' is incorrect for a release event. It should check for a tag reference instead, such as if: startsWith(github.ref, 'refs/tags/').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant