-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sdk release workflow #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to cbbc287 in 46 seconds
More details
- Looked at
41
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/npm-publish-cloud.yml:11
- Draft comment:
The conditionif: github.ref == 'refs/heads/cloud'
is incorrect for a release event. It should check for a tag reference instead, such asif: startsWith(github.ref, 'refs/tags/')
. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_omgL4oIZwHx7O9Ol
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
jobs: | ||
build: | ||
if: github.ref == 'refs/heads/community' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition if: github.ref == 'refs/heads/community'
is incorrect for a release event. It should check for a tag reference instead, such as if: startsWith(github.ref, 'refs/tags/')
.
Important
Change npm publish workflows to trigger on release events and add branch-specific conditions.
push
torelease
event innpm-publish-ce.yml
andnpm-publish-cloud.yml
.github.ref == 'refs/heads/community'
innpm-publish-ce.yml
andgithub.ref == 'refs/heads/cloud'
innpm-publish-cloud.yml
.This description was created by for cbbc287. It will automatically update as commits are pushed.