Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test community sdk publish workflow #88

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Sep 24, 2024

Important

Adds a new GitHub Actions workflow for npm publishing from the community branch and modifies the existing workflow for the main branch.

  • New Workflow:
    • Adds npm-publish-ce.yml for publishing from community branch.
    • Triggered on push with tags v*.*.*.
    • Includes steps for version check and prerelease determination.
  • Modified Workflow:
    • Renames npm-publish.yml to npm-publish-cloud.yml.
    • Changes trigger to push on main branch with tags v*.*.*.
    • Comments out the publish step.

This description was created by Ellipsis for 4c7ab34. It will automatically update as commits are pushed.

@paul-paliychuk paul-paliychuk merged commit 8ce2910 into main Sep 24, 2024
2 checks passed
@paul-paliychuk paul-paliychuk deleted the test-community-sdk-publish-workflow branch September 24, 2024 20:55
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 4c7ab34 in 36 seconds

More details
  • Looked at 106 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/npm-publish-cloud.yml:1
  • Draft comment:
    The comment is misleading as the workflow triggers on push, not on release creation. Consider updating the comment to reflect the actual trigger condition.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_vOBwGZ4i6JDdVGo1


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -0,0 +1,49 @@
# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is misleading as the workflow triggers on push, not on release creation. Consider updating the comment to reflect the actual trigger condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant