-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test community sdk publish workflow #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 4c7ab34 in 36 seconds
More details
- Looked at
106
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/npm-publish-cloud.yml:1
- Draft comment:
The comment is misleading as the workflow triggers on push, not on release creation. Consider updating the comment to reflect the actual trigger condition. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_vOBwGZ4i6JDdVGo1
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -0,0 +1,49 @@ | |||
# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is misleading as the workflow triggers on push, not on release creation. Consider updating the comment to reflect the actual trigger condition.
Important
Adds a new GitHub Actions workflow for npm publishing from the
community
branch and modifies the existing workflow for themain
branch.npm-publish-ce.yml
for publishing fromcommunity
branch.v*.*.*
.npm-publish.yml
tonpm-publish-cloud.yml
.main
branch with tagsv*.*.*
.This description was created by for 4c7ab34. It will automatically update as commits are pushed.