Add Session Facts #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/api/resources/document/client/Client.ts # src/api/resources/memory/client/Client.ts # src/api/resources/user/client/Client.ts
# Conflicts: # package.json # src/api/resources/document/client/Client.ts # src/api/resources/memory/client/Client.ts # src/api/resources/user/client/Client.ts
# Conflicts: # package.json # src/api/resources/document/client/Client.ts # src/api/resources/memory/client/Client.ts # src/api/resources/memory/client/requests/index.ts # src/api/resources/user/client/Client.ts
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to faa8987 in 1.0 minute and 0.5282600000000031 seconds
More details
- Looked at
557lines of code in8files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/api/resources/memory/client/Client.ts:1206
- Draft comment:
The implementation ofaddSessionFactsmethod inMemoryclass is consistent with the existing codebase standards and correctly handles the HTTP interactions and potential errors. Good job on maintaining the code consistency and quality. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a new methodaddSessionFactsin theMemoryclass which allows adding facts to a session. The method correctly handles the HTTP request and response, including error handling. The method signature and implementation align with the existing patterns in the codebase. The PR also includes the necessary updates to the serialization and request structures to support this new functionality.
Workflow ID: wflow_kqXYA4j9J1ddLFEx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added
addSessionFactsmethod toMemoryclass and updated SDK version to1.0.10.Key points:
package.jsonto version1.0.10.src/api/resources/document/client/Client.ts,src/api/resources/memory/client/Client.ts, andsrc/api/resources/user/client/Client.tsto1.0.10.addSessionFactsmethod insrc/api/resources/memory/client/Client.tsto add facts to a session.src/api/resources/memory/client/requests/AddFactsRequest.tsfor theAddFactsRequestinterface.src/api/resources/memory/client/requests/index.tsto exportAddFactsRequest.src/serialization/resources/memory/client/requests/AddFactsRequest.tsfor theAddFactsRequestserializer.src/serialization/resources/memory/client/requests/index.tsto exportAddFactsRequestserializer.Generated with ❤️ by ellipsis.dev