Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen langchain peer dependency requirement #84

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Jul 22, 2024

🚀 This description was created by Ellipsis for commit eedbb81

Summary:

Loosened langchain and @langchain/core peer dependency requirements, updated devDependencies, removed resolutions, deleted an example file, and modified a regex pattern.

Key points:

  • Loosened langchain peer dependency requirements in package.json to >=0.1.19 <0.3.0.
  • Loosened @langchain/core peer dependency requirements in package.json to >=0.1.29 <0.3.0.
  • Updated devDependencies in package.json to allow langchain versions >=0.1.19 <0.3.0.
  • Removed resolutions section from package.json.
  • Deleted examples/langchain/message_history_anthropic_example.ts.
  • Modified regex pattern for formattedPrice in examples/memory/structured_data_extraction_example.ts to /\d+\.\d{2}/.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 99c4a54 in 36.115608 seconds

More details
  • Looked at 43 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. package.json:23
  • Draft comment:
    Changing the peer dependency version for @langchain/core to a range (>=0.1.29 <0.3.0) could introduce compatibility issues if not all versions within this range are tested. Consider specifying a narrower range or ensuring compatibility through testing.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.
2. package.json:24
  • Draft comment:
    Similar to the previous comment on @langchain/core, specifying a version range for langchain (>=0.1.19 <0.3.0) could lead to compatibility issues. Ensure that all versions within this range are compatible or consider a narrower version specification.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_JLBPnYULruP6h1QB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on a757ca7 in 38.385929 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_MmEGdpyEjnZV9Mly


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on eedbb81 in 46.54604 seconds

More details
  • Looked at 88 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. package.json:43
  • Draft comment:
    The langchain version in devDependencies is set to a fixed version 0.1.19, which contradicts the PR description stating it should allow versions >=0.1.19 <0.3.0. Consider updating it to match the intended range.
        "langchain": ">=0.1.19 <0.3.0",
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_6Ss27faAi9LUZaew


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 6a994c7 into main Jul 22, 2024
3 checks passed
@paul-paliychuk paul-paliychuk deleted the loosen-langchain-peer-dependency-requirement branch July 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant