Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): update SDK version and add summary retrieval to Memory #72

Merged
merged 2 commits into from
May 22, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented May 22, 2024

🚀 This description was created by Ellipsis for commit e7ec6c4.

Summary:

Updated SDK version in client headers and extended memory data structure with summary retrieval capabilities.

Key points:

  • Updated X-Fern-SDK-Version from 1.0.2 to 1.0.3 in HTTP headers across multiple client files.
  • Added relevantSummaries field to Memory interface and serialization schema to support new summary retrieval features.

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot changed the title ... feat(client): update SDK version and add summary retrieval to Memory May 22, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e7ec6c4 in 2 minutes and 5 seconds

More details
  • Looked at 365 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/api/resources/document/client/Client.ts:51
  • Draft comment:
    The update of the SDK version from 1.0.2 to 1.0.3 across various client files is consistent and correctly implemented. This change ensures that the server can identify the SDK version being used, which is crucial for analytics, debugging, and potentially altering behavior for different versions.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR updates the SDK version headers across multiple client files. Each change is consistent and correctly increments the version from 1.0.2 to 1.0.3. This is a typical task when a new version of the SDK is released, ensuring that the server can identify the SDK version being used, which is crucial for analytics, debugging, and potentially altering behavior for different versions.

Workflow ID: wflow_PFjJLwMUdTwEl7Rt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit b542e78 into main May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant