Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #107

Merged
merged 12 commits into from
Nov 15, 2024
Merged

V2 #107

merged 12 commits into from
Nov 15, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Nov 15, 2024

Important

Update version to 2.1.1 across multiple files and add cross_encoder to Reranker type.

  • Version Update:
    • Update version to 2.1.1 in package.json and Client.ts files across multiple resources including document, graph, edge, episode, node, group, memory, and user.
  • Reranker Type:
    • Add cross_encoder to Reranker type in Reranker.ts and serialization/types/Reranker.ts.

This description was created by Ellipsis for b824eb9. It will automatically update as commits are pushed.

@paul-paliychuk paul-paliychuk merged commit 16c55d4 into main Nov 15, 2024
2 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to b824eb9 in 1 minute and 1 seconds

More details
  • Looked at 591 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. src/api/types/Reranker.ts:5
  • Draft comment:
    Added "cross_encoder" to the Reranker type. Ensure this change is documented and tested.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates the version number in multiple files, which is consistent with a minor version update. However, the PR description is missing, which makes it unclear what the purpose of the update is. The changes seem to be consistent across all files, indicating a version bump. The addition of "cross_encoder" to the Reranker type and its serialization is a new feature, which justifies the version bump. The changes are consistent and do not introduce any apparent issues.
2. src/serialization/types/Reranker.ts:14
  • Draft comment:
    Spelling error: 'cross_encoder' should be 'cross-encoder'.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_KFujB4YlfkEyHxdp


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -2,11 +2,12 @@
* This file was auto-generated by Fern from our API Definition.
*/

export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions";
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: 'cross_encoder' should be 'cross-encoder'.

Suggested change
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder";
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross-encoder";

@@ -2,11 +2,12 @@
* This file was auto-generated by Fern from our API Definition.
*/

export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions";
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type definition for Reranker is a duplicate of the existing one in src/serialization/types/Reranker.ts. Consider using the existing type instead.

Suggested change
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder";
import { Reranker } from "../../serialization/types/Reranker";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant