-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #107
V2 #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to b824eb9 in 1 minute and 1 seconds
More details
- Looked at
591
lines of code in11
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. src/api/types/Reranker.ts:5
- Draft comment:
Added "cross_encoder" to the Reranker type. Ensure this change is documented and tested. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the version number in multiple files, which is consistent with a minor version update. However, the PR description is missing, which makes it unclear what the purpose of the update is. The changes seem to be consistent across all files, indicating a version bump. The addition of "cross_encoder" to the Reranker type and its serialization is a new feature, which justifies the version bump. The changes are consistent and do not introduce any apparent issues.
2. src/serialization/types/Reranker.ts:14
- Draft comment:
Spelling error: 'cross_encoder' should be 'cross-encoder'. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_KFujB4YlfkEyHxdp
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -2,11 +2,12 @@ | |||
* This file was auto-generated by Fern from our API Definition. | |||
*/ | |||
|
|||
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions"; | |||
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: 'cross_encoder' should be 'cross-encoder'.
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder"; | |
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross-encoder"; |
@@ -2,11 +2,12 @@ | |||
* This file was auto-generated by Fern from our API Definition. | |||
*/ | |||
|
|||
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions"; | |||
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type definition for Reranker
is a duplicate of the existing one in src/serialization/types/Reranker.ts
. Consider using the existing type instead.
- type
Raw
(Reranker.ts)
export type Reranker = "rrf" | "mmr" | "node_distance" | "episode_mentions" | "cross_encoder"; | |
import { Reranker } from "../../serialization/types/Reranker"; |
Important
Update version to 2.1.1 across multiple files and add
cross_encoder
toReranker
type.2.1.1
inpackage.json
andClient.ts
files across multiple resources includingdocument
,graph
,edge
,episode
,node
,group
,memory
, anduser
.cross_encoder
toReranker
type inReranker.ts
andserialization/types/Reranker.ts
.This description was created by for b824eb9. It will automatically update as commits are pushed.