-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Mutiny Wallet #785
Conversation
3591302
to
c88350b
Compare
290cd39
to
35bbe71
Compare
Ready for review! |
35bbe71
to
4b358ab
Compare
#787 Here is the result:Checklist:
|
Will be fixed by: getumbrel/umbrel#1705 |
4b358ab
to
42e67a3
Compare
@ParthJadhav fixed! |
42e67a3
to
9f60537
Compare
Hey @benthecarman that looks good. Thanks for the changes. When I tested it locally it worked properly but when I tested it on a cloud instance where I had multiple other apps. It showing me I even deleted beside from that, When I go to receive money there's a copy to clipboard button won't working since the connection is over |
Not 100% sure, but this might be due to an @benthecarman you have Had a similar issue months ago and that's what fixed it for me. @ParthJadhav what do you think? Could this be it? |
The app ports seems to be fine.
http://umbrel-os.local:14499 (from your browser) -> http://localhost:80 (Inside the container) |
@ParthJadhav that sounds like a port issue, are you sure |
9f60537
to
1c311cc
Compare
Tried something that might work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, That works now. Only thing remaining this to be merged.
Recommending the disability of security features is the wrong approach. Further, it's not just the copy button, there's other browser APIs that depend on HTTPS like camera. And your suggestion to use deprecated APIs and methods is not good. This should only be ran in an HTTPS context, either umbrel should provide this or users should not use HTTPS workarounds but use this with tailscale explicitly. |
Hey @TonyGiorgio, These are some thread regarding the security concerns: https://github.com/getumbrel/umbrel/blob/master/SECURITY.md It's you're right that it's not optimal to disable the security features but it's the team's first priority and hopefully it would be resolved soon. Until then it would be amazing if we could have the features proposed in the above PR. |
It's not going to work for us. Https is a requirement. It's far more than just a copy button not working. What options do we have in having umbrel users installing certs and informing them this is a requirement? |
Thanks for submitting Mutiny Wallet @benthecarman! Excited for this to be self-hosted.
Understood @TonyGiorgio. Let us discuss internally and get back to you. |
I believe I've seen people manually set up their own DNS or tailscale on their umbrel's before. Even if it's something we have to instruct users in the umbrel description, that's an option we can work with. |
@TonyGiorgio @benthecarman, sorry for the delay. We discussed this internally. The https-via-tailscale option may be too finicky for users to set up since it will require running tailscale commands in docker and also configuring the main umbrel nginx which then won't persist on update. One interim option while umbrelOS doesn't support https out-of-the-box could be to serve an SSL cert as part of the mutiny web server. This would involve leg-work on your end in order to implement and walk users through the UX of accepting the cert if http is detected. This option might break the auth proxy so that may need to be disabled. Another possible option with different drawbacks is to instruct users to set up a cloudflare tunnel. There is now a cloudflare app on Umbrel which walks users through setting up a tunnel and public hostnames: https://apps.umbrel.com/app/cloudflared
Obviously we can just wait to add Mutiny Wallet to the app store until we have https support in umbrelOS, but I wanted to give you some options to consider. |
Thanks for that information. We've been very happy with our start9 integration and I think we'll leave it at that for now. That's more effort than I think we (and what I expect out of your type of users) to be able to setup and I don't want to support it. @benthecarman can you close this? We've gone through a few iterations of docker versioning and setup since then. |
Thanks for your efforts on this anyways @benthecarman and @TonyGiorgio, we really appreciate it. We'll reach out when we are providing https out-of-the-box. In the meantime, best of luck with continued success for Mutiny Wallet! |
App Submission
App name
Mutiny Wallet
256x256 SVG icon
https://raw.githubusercontent.com/MutinyWallet/mutiny-web/master/public/mutiny_logo_mask.svg
Gallery images
I have tested my app on: