-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Fulcrum #1531
App Submission: Fulcrum #1531
Conversation
and change restart policy
Regarding app IPs in Currently I have just selected them randomly so as to not conflict with existing Electrs. |
Thanks for submitting Fulcrum @sahilph! We've got our heads down on some other aspects of the codebase, but we have this on our radar and will get to it soon. One quick thought (as a reminder to myself when I come back to this) is that since this is essentially a drop-in replacement for Electrs, we may want to wait until we've implemented a way to choose which app you want to use for a certain protocol (e.g., the electrum protocol). This is on our roadmap. This would allow users to switch to whatever Electrum implementation they want and have it work with all their other bitcoin ecosystem apps that rely on Electrum. Right now, if we bring Fulcrum to the app store, apps like Mempool, BTC RPC Explorer, etc. that depend on an electrum server would not be able to use Fulcrum. Maybe this is okay for now. |
@nmfretz Yes, right. Initially I had set the export variables names to be same as that of Electrs, so that they will be able to use Fulcrum directly, but then I saw the Bitcoin Knots Submission #953, and changed the variables names and also added a note that Fulcrum will be integrated later on, very similar to how it was done for Knots. |
Thanks for your patience @sahilph 🙏
Perfect, really nice work digging in and implementing this. Let's get this shipped then as-is, and in a future umbrelOS update where the apps framework is upgraded (hopefully quite soon) Fulcrum will become hot-swappable with Electrs such that it can be used by apps like mempool, etc. I am currently testing Fulcrum now. Is the UI working for you? Fulcrum is currently building the index:
And is erroring with:
So for some reason fulcrum is refusing connections on port 50002. |
Thank you !
Awesome. Hot Swapping will be great.
Oh yes, I had noticed the errors too during the index building. It keeps on giving those errors. It turns out that, Fulcrum must first fully index the blockchain and compact its database before you can connect to it. |
Ah, ya I see. I don't want to overstep my role here, since I'm really just making sure that the app is packaged correctly for the umbrelOS app store, but could I suggest that the UI be tweaked slightly to avoid user's getting confused? Right now the user will see I'm thinking that user's are going to see this message, notice that their Bitcoin Node is already synced, and think that something is wrong. They have no feedback on what is actually happening behind the scenes. What if you just simplify that component to show something like |
I took the existing umbrel's Electrs app as the base and made some changes to it for Fulcrum.. and that's what it says when it cant connect to Electrs (Yeah, strange !) But it quickly goes aways as Electrs accepts connections even during the initial building..
Oh, I didn't think from that perspective..
Yes that sounds good, I will make that change to the frontend and then reply back.. |
@nmfretz I have updated the docker image which contains the new wording for the wait message. Please check. |
Excellent, thanks for changing that @sahilph. I have pushed a few changes to finalize this submission sahilph/umbrel-apps@09fdef5...9dee7d6 I have tested, and it is working well for me. I have also tested successfully connecting sparrow wallet: The icon and gallery images now live here: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/fulcrum We updated the background of the gallery images to complement the fulcrum logo: Thanks again for all your work bringing Fulcrum to the official app store! |
Awesome Thanks. 👍 |
You guys are awesome! Thx |
App Submission
App name
Fulcrum
Closes #613, also possibly resolves #134
For those who want to try it now, Fulcrum is also available on my personal app store
256x256 SVG icon
https://svgshare.com/i/1Acv.svg
Gallery images
1.jpg:
2.jpg:
3.jpg:
4.jpg:
I have tested my app on: