Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8: Add homepage #3871

Closed
wants to merge 3 commits into from
Closed

pep8: Add homepage #3871

wants to merge 3 commits into from

Conversation

feroxday
Copy link

Summary

pep8: Add homepage https://pycodestyle.pycqa.org/

Checklist

  • Package was built and tested against unstable

**Summary**
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ferox, welcome to Solus!

I started the automatic checks, and it has flagged one issue (look under the "Files changed" tab). Please fix the issue, then amend your commit, and force-push it.

Other than that, great work; thanks for helping with the homepage task.

packages/p/pep8/package.yml Outdated Show resolved Hide resolved
Updated license from Expat to MIT
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

Also, your changes all need to squashed into one commit (the one titled "pep8: Add homepage")

While you are at it, please also add something in the commit description below **Summary**. So your whole commit description looks like this:

pep8: Add homepage

**Summary**
- Add homepage
- Correct license

<Name>Joey Riches</Name>
<Email>[email protected]</Email>
<Name>Nathaniel King</Name>
<Email>[email protected]</Email>
</Packager>
<License>Expat</License>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After making changes, you need to rebuild. Expat is still in the output here.

Updated homepage
Updated license from Expat to MIT
@feroxday feroxday marked this pull request as draft September 21, 2024 23:34
@feroxday feroxday closed this Sep 21, 2024
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're getting there.
But now the package.yml and and the pspec are out of step, and you still need to squash your commits into one.

The steps from here are:

  • change release back to 11, like your initial commit. We only go up by one
  • Kick off another build, so that these changes are in pspec
  • Stage all the changes. Add them to a new commit, or amend them onto your last commit
  • "Squash" all your commits into one. If you're not familiar with this operation, here's the best quick explanation I've found https://www.youtube.com/watch?v=V5KrD7CmO4o
  • Force push the commit, something like git push origin main -f

If you want more interactive help, our Packaging room on Matrix is the place to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants