-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solbuild: Drop fakeroot use, use eopkg.bin #3850
base: main
Are you sure you want to change the base?
Conversation
913f3c1
to
5424598
Compare
I have tried this with the new cargo macro to be able to use multiple binaries but still seems to get issues. |
Tested this PR with |
From what I remember from Serpent OS, @ReillyBrogan also added default RUSTFLAGS that explicitly makes Rust use the release profile, but adds the necessary debugging options for that. Looking at ypkg, it seems like those changes never made it across for safe use of the |
|
Doesn't look like this is using the new ypkg
That's the old logic |
Same error as David.
|
Staudey clued me in: subsequent builds also have to use ermo, I edited your description slightly to point this out. |
I could not build firefox 130.0.1 without tmpfs so I tried this however it fails with a different error: |
Subsequent builds can use either the Test plan in OP updated to reflect this. |
Looks like the cache dir logic might not work properly yet -- possibly due to permissions. Any chance you could chroot into the failed build and check the permissions of the sccache path in the log? |
It appears only YPKG/sources remains so I could not check sccache only cache which it also complained about in the log.
|
Yes, I seemed to have used the old ypkg so my report can be dismissed. |
|
Patched it locally now firefox will fail at the xvfb-run step:
|
@joebonrichie what if we changed the build dir to I think firefox is being too smart for its own good here. |
ypkg is failing to find seemingly specifically glib2 libs with fakeroot-less solbuild. So won't add the needed dep on glib2 in some circumstances.
|
5424598
to
fc9eb29
Compare
fc9eb29
to
13cefcc
Compare
This commit represents a 1.7.0 pre-release build. In my tests, dropping fakeroot is always a bonus. Using eopkg.bin instead of eopkg.py2 can add a slight wall clock overhead. However, this is offset by eopkg.bin being immune to py3 stack upgrade work, which will become increasingly necessary as we work toward removing python2 and eopkg.py2. Note: The present relase still uses eopkg.py2 to build old pspec.xml pkgs. Signed-off-by: Rune Morling <[email protected]>
13cefcc
to
3d9df18
Compare
The version I just pushed was synced with solbuild git master, which is in a 1.7.0-pre state currently. |
Depends on getsolus/eopkg#87 and requires the solbuild image to be rerolled with eopkg.bin so files4.db gets created. |
Summary
Adds the new solbuild with no-fakeroot functionality.
Important note: Landing this PR to -unstable needs to be followed up by updating the solbuild image, otherwise we will get some really annoying failures related to libglib-json moving certain files to a -devel subpackage IIUC.
Test Plan
Build solbuild itself with
gt localcp
, then build a bunch of packages (usinggt local
orgt localcp
) to test the new combo.Checklist