open-iscsi: add at 2.1.0 #3082
Draft
open-iscsi: add at 2.1.0 #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
androidnisse
changed the title
ReillyBrogan
requested changes
Jul 12, 2024
Comment on lines
+23
to
+25
| <Path fileType="config">/etc/isns/isnsadm.conf</Path> | ||
| <Path fileType="config">/etc/isns/isnsd.conf</Path> | ||
| <Path fileType="config">/etc/isns/isnsdd.conf</Path> |
There was a problem hiding this comment.
Have you looked into what it would take to make these configs stateless?
There was a problem hiding this comment.
I had a check now, looked at arch and they had it the same. Fedora did not have this with a quick look.
There was a problem hiding this comment.
I don't know what you mean by that. It doesn't matter what Fedora and Arch do, we make our packages stateless
androidnisse
force-pushed
the
create_open-iscsi
branch
2 times, most recently
from
8d1d142
to
b902b84
Compare
|
Marking it as draft, as this needs to be made stateless |
**Summary** - Initial inclusion
**Summary** - Initial inclusion
androidnisse
force-pushed
the
create_open-iscsi
branch
from
b902b84
to
e0ae546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Checklist