packaging: update commit instructions to follow Git commit hook and link package requests #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add instructions to follow the template shown in the editor. - Remove 'Test Plan' and 'Checklist' from example commits. - Add to packaging changes.
…g PRs Add an issue link to the new package documentation so package requests are automatically resolved. This makes the workflow match more with 'Updating an Existing Package'. No entry to the packaging changes is needed, as linking an issue is also part of 'Creating the pull request' steps.
EbonJaeger
approved these changes
May 25, 2024
| There should be a summary line (with the package name), a blank line, and then the rest of the commit message. | ||
|
|
||
| - There should at the minimum be a Summary and Test Plan. | ||
| - There should at the minimum be a Summary. |
There was a problem hiding this comment.
I was going to quibble with "at the minimum" vs "at a minimum", but apparently this usage is common enough.
LGTM.
davidjharder
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description