ref(debuginfo): Replace dmsort with std sort #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Sep 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
+ Coverage 74.45% 77.44% +2.98%
==========================================
Files 63 61 -2
Lines 15432 14853 -579
==========================================
+ Hits 11490 11503 +13
+ Misses 3942 3350 -592 |
Swatinem
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
tbh, this is a bit suspect. though its possibly explained with identical code folding, where multiple debuginfo entries exist for the same (deduplicated) physical address.
as an aside: I don’t think we need a separate dmsort implementation anymore, as std sort should be the fastest kid in town by now.
|
If we switch to |
loewenheim
changed the title
Swatinem
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using an unstable sorting algorithm (dmsort) to sort symbols upon collection. It behaves differently under Rust 1.81 than 1.80, so some snapshots change.