Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry apps): New error design for external request flow #83678

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Christinarlong
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
23573 2 23571 275
View the top 2 failed tests by shortest run time
tests.sentry.incidents.endpoints.test_organization_alert_rule_details.AlertRuleDetailsGetEndpointTest::test_with_unresponsive_sentryapp
Stack Traces | 4.73s run time
#x1B[1m#x1B[.../incidents/endpoints/test_organization_alert_rule_details.py#x1B[0m:572: in test_with_unresponsive_sentryapp
    assert resp.status_code == 200
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m
tests.sentry.api.endpoints.test_project_rule_details.ProjectRuleDetailsTest::test_with_unresponsive_sentryapp
Stack Traces | 5.8s run time
#x1B[1m#x1B[.../api/endpoints/test_project_rule_details.py#x1B[0m:374: in test_with_unresponsive_sentryapp
    response = self.get_success_response(
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:686: in get_success_response
    assert_status_code(response, status_code)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:40: in assert_status_code
    assert minimum <= response.status_code < maximum, (
#x1B[1m#x1B[31mE   AssertionError: (500, b'{"detail":"Internal Error","errorId":null}')#x1B[0m
#x1B[1m#x1B[31mE   assert 500 < 201#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Base automatically changed from crl/new-sa-error-w-fixes to master January 17, 2025 21:40
).run()

assert (
str(exception_info.value) == "Missing `value` or `label` in option data for SelectField"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are duplicate tests that test cases already covered in prev ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant