fix(merges): Derive projects from group IDs #81434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The developer may be viewing multiple projects, however, they may merge issues belonging to the same project. If all groups belong to the same project, support merging them. Fixes #81433
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Nov 28, 2024
| """Even if the UI calls with multiple projects, if the groups belong to the same project, we should merge them.""" | ||
| projects = [self.create_project(), self.create_project()] | ||
| proj1 = projects[0] | ||
| groups = [self.create_group(proj1), self.create_group(proj1)] |
There was a problem hiding this comment.
Notice that both groups are created for the same project even though the API is going to be called with multiple project ids.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81434 +/- ##
==========================================
+ Coverage 78.45% 80.39% +1.94%
==========================================
Files 7227 7229 +2
Lines 319545 319736 +191
Branches 20803 20803
==========================================
+ Hits 250703 257056 +6353
+ Misses 68449 62287 -6162
Partials 393 393 |
leeandher
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The developer may be viewing multiple projects, however, they may merge issues belonging to the same project.
If all groups belong to the same project, support merging them.
Fixes #81433