Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-crashes): Collect ART Tracer Crashes #81420

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

philipphofmann
Copy link
Member

The Android Runtime Tracer can crash when users enable profiling in the Sentry Android SDK. While the Sentry Android SDK doesn't directly cause these crashes, we want to know when they occur. As Sentry doesn't appear in the stacktrace, we filter for the following specific methods in the specified Android apex packages.

Fixes GH-81172

The Android Runtime Tracer can crash when users enable profiling in the
Sentry Android SDK. While the Sentry Android SDK doesn't directly cause
these crashes, we want to know when they occur. As Sentry doesn't appear
in the stacktrace, we filter for the following specific methods in the
specified Android apex packages.

Fixes GH-81172
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81420   +/-   ##
=======================================
  Coverage   80.38%   80.38%           
=======================================
  Files        7231     7231           
  Lines      319905   319917   +12     
  Branches    20806    20806           
=======================================
+ Hits       257149   257160   +11     
- Misses      62363    62364    +1     
  Partials      393      393           

@philipphofmann philipphofmann merged commit 9a60418 into master Nov 28, 2024
50 checks passed
@philipphofmann philipphofmann deleted the feat/sdk-crashes-art-tracer-crashes branch November 28, 2024 13:56
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
The Android Runtime Tracer can crash when users enable profiling in the
Sentry Android SDK. While the Sentry Android SDK doesn't directly cause
these crashes, we want to know when they occur. As Sentry doesn't appear
in the stacktrace, we filter for the following specific methods in the
specified Android apex packages.

Fixes GH-81172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK Crash Detection: Capture SDK-related crashes with specific signatures
2 participants