fix(similarity): Limit > 30 system frame check to Java #81385
Merged
+168
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
jangjodi
commented
Nov 27, 2024
| @@ -280,7 +293,7 @@ def _process_frames(frames: list[dict[str, Any]]) -> list[str]: | |||
| exc_value = _get_value_if_exists(exception_value) | |||
| elif exception_value.get("id") == "stacktrace" and frame_count < MAX_FRAME_COUNT: | |||
| frame_strings = _process_frames(exception_value["values"]) | |||
| if is_frames_truncated and not app_hash: | |||
| if platform in SYSTEM_FRAME_CHECK_PLATFORMS and is_frames_truncated and not app_hash: | |||
There was a problem hiding this comment.
only raise this exception if the platform is in SYSTEM_FRAME_CHECK_PLATFORMS
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81385 +/- ##
=======================================
Coverage 80.37% 80.37%
=======================================
Files 7231 7231
Lines 319927 319928 +1
Branches 20810 20810
=======================================
+ Hits 257156 257158 +2
+ Misses 62378 62377 -1
Partials 393 393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit > 30 system frame check to Java platform due to bug in grouping info