Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(insights): remove conditional that render module upsell #81342

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Nov 26, 2024

Before domain views were released, we conditionally rendered the module upsells. If the domain views were not enabled we rendered full screen module upsells, otherwise we rendered a body upsell (so that the tabs/headers are retained).

Now that we GA'd domain views, we no longer need these conditions.

This PR also removes the Feature component in the ModuleBodyUpsellHook component. Feature gating already handled in the ModulePageProviders, so there's no reason to do it twice.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 26, 2024
@DominikB2014 DominikB2014 marked this pull request as ready for review November 26, 2024 21:35
@DominikB2014 DominikB2014 requested a review from a team as a code owner November 26, 2024 21:35
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81342      +/-   ##
==========================================
- Coverage   80.38%   80.36%   -0.02%     
==========================================
  Files        7224     7227       +3     
  Lines      319402   319262     -140     
  Branches    20747    20746       -1     
==========================================
- Hits       256742   256573     -169     
- Misses      62267    62296      +29     
  Partials      393      393              

@DominikB2014 DominikB2014 merged commit 2f0fc12 into master Nov 28, 2024
45 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/remove-conditional-module-hook branch November 28, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants