ref: record if transactions ever have plugin tags #79787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it does not seem right that plugin code is allowed to run in the ingest transactions consumer, i believe it should be post process only this is just a validation step to verify if this is actually doing anything anyway so we can determine if it is safe to remove later
github-actions
bot
added
the
Scope: Backend
JoshFerge
reviewed
Oct 25, 2024
JoshFerge
approved these changes
Oct 25, 2024
Co-authored-by: Josh Ferge <[email protected]>
|
confirmed this is used and probably can't be safely removed, reverting |
|
PR reverted: d8c5335 |
getsentry-bot
added a commit
that referenced
this pull request
Oct 28, 2024
This reverts commit 7773aca. Co-authored-by: lynnagara <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it does not seem right that plugin code is allowed to run in the ingest transactions consumer, i believe it should be post process only
this is just a validation step to verify if this is actually doing anything anyway so we can determine if it is safe to remove later