chore(dashboards): Remove releases on widget charts ff (#81317)

removing all instances of the `dashboards-releases-on-charts` ff because it has been fully rolled out.
getsentry · Nov 26, 2024 · d66e44f · d66e44f
1 parent 95cba0c
commit d66e44f
Show file tree

Hide file tree

Showing 13 changed files with 41 additions and 10 deletions.
diff --git a/static/app/components/modals/widgetBuilder/addToDashboardModal.spec.tsx b/static/app/components/modals/widgetBuilder/addToDashboardModal.spec.tsx
@@ -97,6 +97,11 @@ describe('add to dashboard modal', () => {
       body: testDashboard,
     });
 
+    MockApiClient.addMockResponse({
+      url: '/organizations/org-slug/releases/stats/',
+      body: [],
+    });
+
     eventsStatsMock = MockApiClient.addMockResponse({
       url: '/organizations/org-slug/events-stats/',
       body: [],

diff --git a/static/app/components/modals/widgetBuilder/addToDashboardModal.tsx b/static/app/components/modals/widgetBuilder/addToDashboardModal.tsx
@@ -306,7 +306,6 @@ function AddToDashboardModal({
                     widgetLegendState={widgetLegendState}
                     onLegendSelectChanged={() => {}}
                     legendOptions={
-                      organization.features.includes('dashboards-releases-on-charts') &&
                       widgetLegendState.widgetRequiresLegendUnselection(widget)
                         ? {selected: unselectedReleasesForCharts}
                         : undefined

diff --git a/static/app/components/modals/widgetViewerModal.spec.tsx b/static/app/components/modals/widgetViewerModal.spec.tsx
@@ -131,6 +131,11 @@ describe('Modals -> WidgetViewerModal', function () {
       body: [],
     });
 
+    MockApiClient.addMockResponse({
+      url: '/organizations/org-slug/releases/stats/',
+      body: [],
+    });
+
     eventsMetaMock = MockApiClient.addMockResponse({
       url: '/organizations/org-slug/events-meta/',
       body: {count: 33323612},

diff --git a/static/app/views/dashboards/dashboard.spec.tsx b/static/app/views/dashboards/dashboard.spec.tsx
@@ -86,6 +86,10 @@ describe('Dashboards > Dashboard', () => {
       method: 'POST',
       body: [],
     });
+    MockApiClient.addMockResponse({
+      url: `/organizations/org-slug/releases/stats/`,
+      body: [],
+    });
     MockApiClient.addMockResponse({
       url: '/organizations/org-slug/events-stats/',
       method: 'GET',

diff --git a/static/app/views/dashboards/detail.spec.tsx b/static/app/views/dashboards/detail.spec.tsx
@@ -100,6 +100,10 @@ describe('Dashboards > Detail', function () {
         url: '/organizations/org-slug/releases/',
         body: [],
       });
+      MockApiClient.addMockResponse({
+        url: '/organizations/org-slug/releases/stats/',
+        body: [],
+      });
       MockApiClient.addMockResponse({
         url: '/organizations/org-slug/metrics/meta/',
         body: [],
@@ -368,6 +372,10 @@ describe('Dashboards > Detail', function () {
         url: '/organizations/org-slug/releases/',
         body: [],
       });
+      MockApiClient.addMockResponse({
+        url: '/organizations/org-slug/releases/stats/',
+        body: [],
+      });
       MockApiClient.addMockResponse({
         url: '/organizations/org-slug/sdk-updates/',
         body: [],

diff --git a/static/app/views/dashboards/widgetBuilder/buildSteps/visualizationStep.tsx b/static/app/views/dashboards/widgetBuilder/buildSteps/visualizationStep.tsx
@@ -141,7 +141,6 @@ export function VisualizationStep({
           shouldResize={false}
           onLegendSelectChanged={() => {}}
           legendOptions={
-            organization.features.includes('dashboards-releases-on-charts') &&
             widgetLegendState.widgetRequiresLegendUnselection(widget)
               ? {selected: unselectedReleasesForCharts}
               : undefined

diff --git a/static/app/views/dashboards/widgetBuilder/widgetBuilder.spec.tsx b/static/app/views/dashboards/widgetBuilder/widgetBuilder.spec.tsx
@@ -265,6 +265,10 @@ describe('WidgetBuilder', function () {
       url: '/organizations/org-slug/releases/',
       body: [],
     });
+    MockApiClient.addMockResponse({
+      url: '/organizations/org-slug/releases/stats/',
+      body: [],
+    });
     MockApiClient.addMockResponse({
       url: `/organizations/org-slug/spans/fields/`,
       body: [],

diff --git a/static/app/views/dashboards/widgetBuilder/widgetBuilderDataset.spec.tsx b/static/app/views/dashboards/widgetBuilder/widgetBuilderDataset.spec.tsx
@@ -276,6 +276,10 @@ describe('WidgetBuilder', function () {
       url: '/organizations/org-slug/releases/',
       body: [],
     });
+    MockApiClient.addMockResponse({
+      url: '/organizations/org-slug/releases/stats/',
+      body: [],
+    });
     MockApiClient.addMockResponse({
       url: `/organizations/org-slug/spans/fields/`,
       body: [],

diff --git a/static/app/views/dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx b/static/app/views/dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx
@@ -236,6 +236,10 @@ describe('WidgetBuilder', function () {
       url: '/organizations/org-slug/releases/',
       body: [],
     });
+    MockApiClient.addMockResponse({
+      url: '/organizations/org-slug/releases/stats/',
+      body: [],
+    });
     MockApiClient.addMockResponse({
       url: `/organizations/org-slug/spans/fields/`,
       body: [],

diff --git a/static/app/views/dashboards/widgetCard/chart.tsx b/static/app/views/dashboards/widgetCard/chart.tsx
@@ -297,7 +297,6 @@ class WidgetCardChart extends Component<WidgetCardChartProps> {
       chartZoomOptions,
       timeseriesResultsTypes,
       shouldResize,
-      organization,
     } = this.props;
 
     if (widget.displayType === 'table') {
@@ -524,8 +523,7 @@ class WidgetCardChart extends Component<WidgetCardChartProps> {
 
           const forwardedRef = this.props.chartGroup ? this.handleRef : undefined;
 
-          return organization.features.includes('dashboards-releases-on-charts') &&
-            widgetLegendState.widgetRequiresLegendUnselection(widget) ? (
+          return widgetLegendState.widgetRequiresLegendUnselection(widget) ? (
             <ReleaseSeries
               end={end}
               start={start}

diff --git a/static/app/views/dashboards/widgetCard/index.spec.tsx b/static/app/views/dashboards/widgetCard/index.spec.tsx
@@ -104,6 +104,10 @@ describe('Dashboards > WidgetCard', function () {
         data: [{title: 'title'}],
       },
     });
+    MockApiClient.addMockResponse({
+      url: '/organizations/org-slug/releases/stats/',
+      body: [],
+    });
   });
 
   afterEach(function () {

diff --git a/static/app/views/dashboards/widgetLegendSelectionState.spec.tsx b/static/app/views/dashboards/widgetLegendSelectionState.spec.tsx
@@ -49,7 +49,6 @@ describe('WidgetLegend functions util', () => {
       };
       organization = {
         ...OrganizationFixture(),
-        features: ['dashboards-releases-on-charts'],
       };
 
       dashboard = {

diff --git a/static/app/views/dashboards/widgetLegendSelectionState.tsx b/static/app/views/dashboards/widgetLegendSelectionState.tsx
@@ -121,8 +121,7 @@ class WidgetLegendSelectionState {
 
     return location.query.unselectedSeries
       ? this.decodeLegendQueryParam(widget)
-      : this.widgetRequiresLegendUnselection(widget) &&
-          this.organization.features.includes('dashboards-releases-on-charts')
+      : this.widgetRequiresLegendUnselection(widget)
         ? {
             [WidgetLegendNameEncoderDecoder.encodeSeriesNameForLegend(
               'Releases',
@@ -148,8 +147,7 @@ class WidgetLegendSelectionState {
   }
 
   formatLegendDefaultQuery(widget: Widget) {
-    return this.organization.features.includes('dashboards-releases-on-charts') &&
-      this.widgetRequiresLegendUnselection(widget)
+    return this.widgetRequiresLegendUnselection(widget)
       ? `${widget.id}${WIDGET_ID_DELIMITER}Releases`
       : undefined;
   }