feat(explore): Support profile.id (#81318)

getsentry · Nov 26, 2024 · cbc4a8c · cbc4a8c
1 parent a4ac88d
commit cbc4a8c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/static/app/utils/discover/fieldRenderers.tsx b/static/app/utils/discover/fieldRenderers.tsx
@@ -546,7 +546,7 @@ const SPECIAL_FIELDS: SpecialFields = {
     sortField: 'profile.id',
     renderFunc: data => {
       const id: string | unknown = data?.['profile.id'];
-      if (typeof id !== 'string') {
+      if (typeof id !== 'string' || id === '') {
         return emptyValue;
       }
 

diff --git a/static/app/views/explore/contexts/spanTagsContext.tsx b/static/app/views/explore/contexts/spanTagsContext.tsx
@@ -70,6 +70,7 @@ export function SpanTagsProvider({children, dataset, enabled}: SpanTagsProviderP
       // as we're moving toward span ids
 
       'id', // SpanIndexedField.SPAN_OP is actually `span_id`
+      'profile.id', // SpanIndexedField.PROFILE_ID is actually `profile_id`
       SpanIndexedField.BROWSER_NAME,
       SpanIndexedField.ENVIRONMENT,
       SpanIndexedField.ORIGIN_TRANSACTION,

diff --git a/static/app/views/explore/tables/fieldRenderer.tsx b/static/app/views/explore/tables/fieldRenderer.tsx
@@ -9,6 +9,7 @@ import {getFieldRenderer} from 'sentry/utils/discover/fieldRenderers';
 import {Container} from 'sentry/utils/discover/styles';
 import {generateLinkToEventInTraceView} from 'sentry/utils/discover/urls';
 import {getShortEventId} from 'sentry/utils/events';
+import {generateProfileFlamechartRouteWithQuery} from 'sentry/utils/profiling/routes';
 import {MutableSearch} from 'sentry/utils/tokenizeSearch';
 import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
@@ -78,6 +79,15 @@ export function FieldRenderer({data, meta, unit, column}: FieldProps) {
     rendered = <Link to={target}>{rendered}</Link>;
   }
 
+  if (field === 'profile.id') {
+    const target = generateProfileFlamechartRouteWithQuery({
+      orgSlug: organization.slug,
+      projectSlug: data.project,
+      profileId: data['profile.id'],
+    });
+    rendered = <Link to={target}>{rendered}</Link>;
+  }
+
   return (
     <CellAction
       column={column}