fix(rpc): Handle transaction correctly (#81071)

- Transaction accidentally had the is_event_id validator on it
getsentry · Nov 20, 2024 · a213dc8 · a213dc8
1 parent aa58942
commit a213dc8
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/src/sentry/search/eap/columns.py b/src/sentry/search/eap/columns.py
@@ -254,7 +254,6 @@ def simple_measurements_field(field) -> ResolvedColumn:
             public_alias="transaction",
             internal_name="sentry.segment_name",
             search_type="string",
-            validator=is_event_id,
         ),
         ResolvedColumn(
             public_alias="replay.id",

diff --git a/tests/snuba/api/endpoints/test_organization_events_span_indexed.py b/tests/snuba/api/endpoints/test_organization_events_span_indexed.py
@@ -698,6 +698,38 @@ def test_environment(self):
             {"environment": "prod", "count()": 1},
         ]
 
+    def test_transaction(self):
+        self.store_spans(
+            [
+                self.create_span(
+                    {"description": "foo", "sentry_tags": {"transaction": "bar"}},
+                    start_ts=self.ten_mins_ago,
+                ),
+            ],
+            is_eap=self.is_eap,
+        )
+        response = self.do_request(
+            {
+                "field": ["description", "count()"],
+                "query": "transaction:bar",
+                "orderby": "description",
+                "project": self.project.id,
+                "dataset": self.dataset,
+            }
+        )
+
+        assert response.status_code == 200, response.content
+        data = response.data["data"]
+        meta = response.data["meta"]
+        assert len(data) == 1
+        assert data == [
+            {
+                "description": "foo",
+                "count()": 1,
+            },
+        ]
+        assert meta["dataset"] == self.dataset
+
 
 class OrganizationEventsEAPSpanEndpointTest(OrganizationEventsSpanIndexedEndpointTest):
     is_eap = True