-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(alerts): Drop included and excluded projects (#81250)
Follow up to #81204 to fully remove `excluded_projects` and `include_all_projects` from the `AlertRule` model which was blocking removing the `AlertRuleExcludedProjects` table.
- Loading branch information
Showing
2 changed files
with
37 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/sentry/migrations/0795_drop_included_excluded_projects.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Generated by Django 5.1.1 on 2024-11-25 17:33 | ||
|
||
from sentry.new_migrations.migrations import CheckedMigration | ||
from sentry.new_migrations.monkey.fields import SafeRemoveField | ||
from sentry.new_migrations.monkey.state import DeletionAction | ||
|
||
|
||
class Migration(CheckedMigration): | ||
# This flag is used to mark that a migration shouldn't be automatically run in production. | ||
# This should only be used for operations where it's safe to run the migration after your | ||
# code has deployed. So this should not be used for most operations that alter the schema | ||
# of a table. | ||
# Here are some things that make sense to mark as post deployment: | ||
# - Large data migrations. Typically we want these to be run manually so that they can be | ||
# monitored and not block the deploy for a long period of time while they run. | ||
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to | ||
# run this outside deployments so that we don't block them. Note that while adding an index | ||
# is a schema change, it's completely safe to run the operation after the code has deployed. | ||
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment | ||
|
||
is_post_deployment = False | ||
|
||
dependencies = [ | ||
("sentry", "0794_rm_excluded_included_projects_alertrule"), | ||
] | ||
|
||
operations = [ | ||
SafeRemoveField( | ||
model_name="alertrule", name="excluded_projects", deletion_action=DeletionAction.DELETE | ||
), | ||
SafeRemoveField( | ||
model_name="alertrule", | ||
name="include_all_projects", | ||
deletion_action=DeletionAction.DELETE, | ||
), | ||
] |