Skip to content

Don't gate request query strings and form data behind send_default_pii

Codecov / codecov/project failed Oct 31, 2024 in 1s

58.07% (-0.42%) compared to d7522f9

View this Pull Request on Codecov

58.07% (-0.42%) compared to d7522f9

Details

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.07%. Comparing base (d7522f9) to head (f1c1f1f).

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/interfaces/request.rb 0.00% 3 Missing ⚠️
sentry-ruby/lib/sentry/faraday.rb 0.00% 2 Missing ⚠️
sentry-ruby/lib/sentry/net/http.rb 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           6.0-dev    #2452      +/-   ##
===========================================
- Coverage    58.48%   58.07%   -0.42%     
===========================================
  Files          117      117              
  Lines         4401     4396       -5     
===========================================
- Hits          2574     2553      -21     
- Misses        1827     1843      +16     
Components Coverage Δ
sentry-ruby 53.84% <0.00%> (-0.55%) ⬇️
sentry-rails 46.36% <ø> (ø)
sentry-sidekiq 97.63% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/faraday.rb 38.23% <0.00%> (+2.12%) ⬆️
sentry-ruby/lib/sentry/net/http.rb 41.66% <0.00%> (+2.19%) ⬆️
sentry-ruby/lib/sentry/interfaces/request.rb 33.89% <0.00%> (+0.56%) ⬆️

... and 4 files with indirect coverage changes