[rails] support string errors in error reporter #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2464 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 126 126
Lines 4761 4765 +4
=======================================
+ Hits 4672 4676 +4
Misses 89 89
|
sl0thentr0py
requested changes
Nov 14, 2024
| when Exception | ||
| Sentry::Rails.capture_exception(error, **options) | ||
| else | ||
| raise ArgumentError, "Expected an Exception or a String, got: #{error.inspect}" |
There was a problem hiding this comment.
we should not raise inside the SDK, let's use log_debug here
There was a problem hiding this comment.
@sl0thentr0py hmm, what's the best way of accessing logger though? I can see that the helper is defined in the LoggingHelper, but not sure which object I should use for logging, or if I should include that helper in the ErrorSubscriber?
There was a problem hiding this comment.
yes you can just include it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2460