Fix send_default_pii handling in rails controller spans #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/fix-rails-pii-params
branch
from
7c1c4f8
to
e062dfa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
==========================================
- Coverage 98.34% 98.18% -0.17%
==========================================
Files 126 126
Lines 4705 4726 +21
==========================================
+ Hits 4627 4640 +13
- Misses 78 86 +8
|
The change in #1793 accidentally exposed params always in the controller action span. This change now respects both `Rails.config.filter_parameters` and `Sentry.coniguration.send_default_pii` together to decide what to send.
sl0thentr0py
force-pushed
the
neel/fix-rails-pii-params
branch
from
e062dfa
to
a566efb
Compare
sentrivana
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #1973 accidentally exposed
paramsalways in the controller action span. This change now respects bothRails.config.filter_parametersandSentry.configuration.send_default_piitogether to decide what to send.fixes #2438