Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize size limits based on envelope item type #2421

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Generalize size limits based on envelope item type #2421

merged 8 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. Fix spec file location

    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    802c239 View commit details
    Browse the repository at this point in the history

  2. Extract Envelope::Item to its own file

    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cd90baf View commit details
    Browse the repository at this point in the history

  3. Add Envelope::Item#size_limit

    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    35e6a11 View commit details
    Browse the repository at this point in the history

  4. Make Envelope::Item#{headers,payload} just readers 

    We don't set headers and payloads after initializing an item, so these
accessors were not needed.
    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b721841 View commit details
    Browse the repository at this point in the history

  5. Memoize Envelope::Item#type in the constructor 

    It's faster like that given that we rely on type value in multiple
places
    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    332a94c View commit details
    Browse the repository at this point in the history

  6. Memoize Envelope::Item#data_category 

    Same as with type, we rely on this value in multiple places so it makes
no sense to keep calculating it multiple times
    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8964c60 View commit details
    Browse the repository at this point in the history

  7. Add custom size limit for profile items

    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b1f8edb View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG

    @solnic
    solnic committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0aafa71 View commit details
    Browse the repository at this point in the history