Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child_spans for Sidekiq Queue instrumentation #2403

Merged

Dont use .day helper

5e000c6
Select commit
Loading
Failed to load commit list.
Merged

Add child_spans for Sidekiq Queue instrumentation #2403

Dont use .day helper
5e000c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 28, 2024 in 0s

98.16% (-0.03%) compared to 27d7384

View this Pull Request on Codecov

98.16% (-0.03%) compared to 27d7384

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (27d7384) to head (5e000c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2403      +/-   ##
==========================================
- Coverage   98.18%   98.16%   -0.03%     
==========================================
  Files         123      126       +3     
  Lines        4636     4741     +105     
==========================================
+ Hits         4552     4654     +102     
- Misses         84       87       +3     
Components Coverage Δ
sentry-ruby 98.51% <ø> (ø)
sentry-rails 97.05% <ø> (ø)
sentry-sidekiq 97.63% <100.00%> (+0.15%) ⬆️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (∅)
sentry-opentelemetry 99.31% <ø> (+0.68%) ⬆️
Files with missing lines Coverage Δ
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 98.21% <100.00%> (+0.53%) ⬆️

... and 4 files with indirect coverage changes