feat(flags): Add LaunchDarkly integration #14207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try-javascript into aliu/launch-darkly
…try-javascript into aliu/launch-darkly
…ag field and methods
aliu39
commented
Nov 7, 2024
aliu39
commented
Nov 8, 2024
aliu39
force-pushed
the
aliu/launch-darkly-integration
branch
from
2ba9592
to
d8f2d72
Compare
billyvg
reviewed
Nov 13, 2024
dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/init.js
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Nov 13, 2024
...es/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/withScope/test.ts
Outdated
Show resolved
Hide resolved
aliu39
force-pushed
the
aliu/launch-darkly-integration
branch
from
d8f2d72
to
7a5f29d
Compare
aliu39
commented
Nov 13, 2024
billyvg
reviewed
Nov 13, 2024
aliu39
force-pushed
the
aliu/launch-darkly-integration
branch
from
ab1bb31
to
8479826
Compare
aliu39
force-pushed
the
aliu/launch-darkly-integration
branch
from
8479826
to
a2ba257
Compare
billyvg
reviewed
Nov 14, 2024
Comment on lines
+25
to
+33
| await page.waitForFunction(bufferSize => { | ||
| const ldClient = (window as any).initializeLD(); | ||
| for (let i = 1; i <= bufferSize; i++) { | ||
| ldClient.variation(`feat${i}`, false); | ||
| } | ||
| ldClient.variation(`feat${bufferSize + 1}`, true); // eviction | ||
| ldClient.variation('feat3', true); // update | ||
| return true; | ||
| }, FLAG_BUFFER_SIZE); |
There was a problem hiding this comment.
This can just be page.evaluate right since we're not waiting for anything async inside
Comment on lines
+28
to
+48
| await page.waitForFunction(() => { | ||
| const Sentry = (window as any).Sentry; | ||
| const errorButton = document.querySelector('#error') as HTMLButtonElement; | ||
| const ldClient = (window as any).initializeLD(); | ||
|
|
||
| ldClient.variation('shared', true); | ||
|
|
||
| Sentry.withScope((scope: Scope) => { | ||
| ldClient.variation('forked', true); | ||
| ldClient.variation('shared', false); | ||
| scope.setTag('isForked', true); | ||
| if (errorButton) { | ||
| errorButton.click(); | ||
| } | ||
| }); | ||
|
|
||
| ldClient.variation('main', true); | ||
| Sentry.getCurrentScope().setTag('isForked', false); | ||
| errorButton.click(); | ||
| return true; | ||
| }); |
| * | ||
| * @returns `true` if we should skip the launchdarkly test | ||
| */ | ||
| export function shouldSkipLaunchDarklyTest(): boolean { |
There was a problem hiding this comment.
Should this be more generic? e.g. feature flags instead of just launch darkly, esp if we're going to add other vendors.
Suggested change
| export function shouldSkipLaunchDarklyTest(): boolean { | |
| export function shouldSkipLaunchDarklyTest(): boolean { |
billyvg
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a browser integration for tracking feature flag evaluations through the LaunchDarkly JS SDK.
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
LDInspectionFlagUsedHandler) separately from theSentry.init()call, since the only way to do so is in [LD].initialize().