Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoredTransactions option to filter out transactions by name #3871

Merged
merged 14 commits into from
Nov 12, 2024

Conversation

adinauer
Copy link
Member

📜 Description

Add ignoredTransactions option to filter out transactions by name

  • can be used via ENV vars, e.g. SENTRY_IGNORED_TRANSACTIONS=POST /person/,GET /pers.*
  • can also be set in options directly, e.g. options.setIgnoredTransactions(...)
  • can also be set in sentry.properties, e.g. ignored-transactions=POST /person/,GET /pers.*
  • can also be set in Spring config application.properties, e.g. sentry.ignored-transactions=POST /person/,GET /pers.*

💡 Motivation and Context

Fixes #3840

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6ec4a72

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.19 ms 438.14 ms 28.95 ms
Size 1.65 MiB 2.31 MiB 673.06 KiB

Previous results on branch: feat/ignore-transactions

Startup times

Revision Plain With Sentry Diff
8b49db6 455.65 ms 478.47 ms 22.82 ms

App size

Revision Plain With Sentry Diff
8b49db6 1.70 MiB 2.36 MiB 671.74 KiB

Base automatically changed from feat/status-code-mapping-3xx to 8.x.x November 11, 2024 16:59
options
.getClientReportRecorder()
.recordLostEvent(
DiscardReason.EVENT_PROCESSOR, DataCategory.Span, transaction.getSpans().size() + 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the +1 here do? Is that to account for the transaction?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, same as further down.

sentry/src/main/java/io/sentry/util/TracingUtils.java Outdated Show resolved Hide resolved
@adinauer adinauer merged commit f3c4ab7 into 8.x.x Nov 12, 2024
31 checks passed
@adinauer adinauer deleted the feat/ignore-transactions branch November 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants