Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 53 - Automatically set span factory based on presence of OpenTelemetry #3858

Merged
merged 8 commits into from
Nov 11, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 7, 2024

📜 Description

Previously OtelSpanFactory had to be set by an integration or the customer (manually). The SDK now auto detects the presence of OpenTelemetry and then sets OtelSpanFactory by default.

Also SentrySpanFactoryHolder is no longer needed (since we moved classes into the bootstrap classloader) and has been removed.

There is now a system-test-run.sh script to run all system tests locally without having to build the command manually.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7335384

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.80 ms 433.42 ms 36.62 ms
Size 1.65 MiB 2.31 MiB 672.94 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/no-agent-sample-fix-ignored-instrumentation to 8.x.x November 11, 2024 15:30
@adinauer adinauer merged commit b795cb4 into 8.x.x Nov 11, 2024
20 of 27 checks passed
@adinauer adinauer deleted the feat/spanfactoryfactory branch November 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants