Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Add beforeSendReplay callback #3855

Open
wants to merge 3 commits into
base: rz/feat/session-replay-rate-limiting
Choose a base branch
from

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 6, 2024

📜 Description

  • Add beforeSendReplay callback to allow attaching tags and modifying/dropping events analogous to beforeSend

💡 Motivation and Context

Part of getsentry/sentry#74441

💚 How did you test it?

Automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [] I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Docs

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.98 ms 394.89 ms 37.91 ms
Size 1.70 MiB 2.35 MiB 668.62 KiB

Baseline results on branch: rz/feat/session-replay-rate-limiting

Startup times

Revision Plain With Sentry Diff
6366b22 392.38 ms 452.42 ms 60.04 ms

App size

Revision Plain With Sentry Diff
6366b22 1.70 MiB 2.35 MiB 668.54 KiB

Previous results on branch: rz/feat/session-replay-before-send

Startup times

Revision Plain With Sentry Diff
debde9e 441.62 ms 480.76 ms 39.14 ms

App size

Revision Plain With Sentry Diff
debde9e 1.70 MiB 2.35 MiB 668.66 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants