Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into 8.x.x with most recent release being 7.16.0 #3838

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Merge main into 8.x.x with most recent release being 7.16.0 #3838

merged 3 commits into from
Nov 8, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 31, 2024 •
edited
Loading

#skip-changelog

📜 Description

Merge main into 8.x.x with most recent release being 7.16.0

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1f28a4d

@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.83 ms 462.82 ms 34.99 ms
Size 1.70 MiB 2.36 MiB 672.17 KiB

stefanosiano
stefanosiano reviewed Oct 31, 2024
View reviewed changes
sentry/src/main/java/io/sentry/metrics/MetricsHelper.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed, right?

stefanosiano
stefanosiano reviewed Oct 31, 2024
View reviewed changes
sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed, too

stefanosiano
stefanosiano approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just 2 empty files to remove

@adinauer adinauer merged commit e5e4336 into 8.x.x Nov 8, 2024
5 of 19 checks passed
@adinauer adinauer deleted the feat/merge-main-into-8-x-7-16 branch November 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @stefanosiano