Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(okhttp): update documented default value to match actual #3800

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

marcin-kozinski
Copy link
Contributor

@marcin-kozinski marcin-kozinski commented Oct 17, 2024

#skip-changelog

📜 Description

Update the documented default value for captureFailedRequests to match the actual default value in code.

💡 Motivation and Context

Looks like you forgot to update the docs when you flipped the default in 7.1.0 😅

💚 How did you test it?

🫣

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR!
yeah, we overlooked it 😅

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks for the PR @marcin-kozinski !

@stefanosiano stefanosiano merged commit eb5d294 into getsentry:main Oct 17, 2024
27 checks passed
@marcin-kozinski marcin-kozinski deleted the patch-1 branch October 17, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants