Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Class.getName
instead ofClass.getCanonicalName
as seems like the latter is quite a bit slower due to checks for class locality/anonymity which goes into the native layer. Maybe an outlier, but they are essentially the same thing except a couple of cases, so I think it's fine to use it herepositionInWindow
call as we already get the coords viaboundsInWindow
anywayrunInBackground
init call as it wouldn't do anything because ReplayCache is null at that point anywayBefore (canonicalName change)
After (canonicalName change)
💚 How did you test it?
Existing tests should cover it
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps