Instantiate continuous profiling v8 (p3) #3725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed isProfilingEnabled from AndroidContinuousProfiler, as it's useless added continuous profiler to SentryOptions
…ontinuous-profiling-part3 # Conflicts: # sentry/src/main/java/io/sentry/SentryTracer.java # sentry/src/test/java/io/sentry/OutboxSenderTest.kt
…iler updated DefaultTransactionPerformanceCollector to work with string ids other than transactions fixed ProfileChunk measurements being modifiable from other code added thread id and name to SpanContext.data
7 tasks
stefanosiano
changed the title
stefanosiano
changed the base branch from
main
to
feat/continuous-profiling-part2
|
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
Performance metrics 🚀
|
romtsn
reviewed
Nov 11, 2024
sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 11, 2024
romtsn
reviewed
Nov 11, 2024
| @@ -119,6 +126,14 @@ public SpanContext(final @NotNull SpanContext spanContext) { | |||
| if (copiedUnknown != null) { | |||
| this.unknown = copiedUnknown; | |||
| } | |||
| this.instrumenter = spanContext.instrumenter; | |||
There was a problem hiding this comment.
just wanna check with @adinauer if this was just missed, or intended to not copy those?
romtsn
reviewed
Nov 11, 2024
romtsn
reviewed
Nov 11, 2024
| @@ -86,6 +86,12 @@ public SentryTracer( | |||
| this.baggage = new Baggage(scopes.getOptions().getLogger()); | |||
| } | |||
|
|
|||
| final @NotNull SentryId continuousProfilerId = | |||
There was a problem hiding this comment.
just a thought: I'd imagine this would be better living on the Scope(s), but since it's a global profiler it's probably fine.
romtsn
reviewed
Nov 11, 2024
There was a problem hiding this comment.
LGTM, but one comment about where we send profiler_id:
- I don't know about backend implications, but why don't we make
profiler_idpart of the baggage/trace-header? I'd imagine it'd make sense to have it there to make sampling decisions for spans/txs etc etc, or is it already supposed to work with spans-without-sampling? Just did the same thing for replays recently, that's why I'm asking, because there it differs from this approach a little.
romtsn
approved these changes
Nov 11, 2024
…rofiling-part3 # Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java # sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java # sentry-android-ndk/build.gradle.kts # sentry/api/sentry.api # sentry/src/main/java/io/sentry/Scopes.java # sentry/src/main/java/io/sentry/SpanContext.java # sentry/src/main/java/io/sentry/protocol/SentryTransaction.java # sentry/src/test/java/io/sentry/CheckInSerializationTest.kt # sentry/src/test/java/io/sentry/JsonSerializerTest.kt # sentry/src/test/java/io/sentry/SentryOptionsTest.kt # sentry/src/test/java/io/sentry/protocol/SpanContextSerializationTest.kt
Chunks are not bound to traces at the moment, but I agree on your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added profile context to SentryTracer
removed isProfilingEnabled from AndroidContinuousProfiler, as it's useless
added continuous profiler to SentryOptions
added DefaultTransactionPerformanceCollector to AndroidContinuousProfiler and updated it to work with string ids other than transactions
fixed ProfileChunk measurements being modifiable from other code
added thread id and name to SpanContext.data
#skip-changelog
💡 Motivation and Context
Instantiate Continuous Profiler
Part 3 of #3710
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps