Change payload for Continuous Profiling v8 (p2) #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added IHub.captureProfileChunk and ISentryClient.captureProfileChunk added profilerId and chunkId reset logic to AndroidContinuousProfiler added absolute timestamps to ProfileMeasurementValue added ProfileContext to Contexts
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
7 tasks
|
Performance metrics 🚀
|
…ontinuous-profiling-part2
7 tasks
romtsn
reviewed
Nov 11, 2024
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 11, 2024
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Show resolved
Hide resolved
romtsn
reviewed
Nov 11, 2024
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Show resolved
Hide resolved
romtsn
reviewed
Nov 11, 2024
romtsn
approved these changes
Nov 11, 2024
…ta, now it uses timestamp.nanotime() to achieve same result profiler resets chunk id and profiler id in case profile is not recorded due to an error
…rofiling-part2 # Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java # sentry-android-core/src/main/java/io/sentry/android/core/AndroidProfiler.java # sentry/api/sentry.api # sentry/src/main/java/io/sentry/HubAdapter.java # sentry/src/test/java/io/sentry/protocol/ContextsTest.kt
romtsn
reviewed
Nov 11, 2024
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Nov 11, 2024
…ntinue scheduling restart
romtsn
reviewed
Nov 12, 2024
| options | ||
| .getExecutorService() | ||
| .submit( | ||
| () -> { |
There was a problem hiding this comment.
oh, one more thing I forgot - we should probably have a AtomicBoolean isClosed value that we set in close() and check here to prevent sending chunks when the sdk is closing, wdyt?
There was a problem hiding this comment.
ok, i'll do it in a followup pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added profile_chunk envelope create
added IHub.captureProfileChunk and ISentryClient.captureProfileChunk
added profilerId and chunkId reset logic to AndroidContinuousProfiler
added absolute timestamps to ProfileMeasurementValue
added ProfileContext to Contexts
#skip-changelog
💡 Motivation and Context
Implements payload changes for Continuous Profiling
Part 2 of #3710
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps