Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POTEL 48 - Cleanup POTel TODOs #3705

Merged
merged 12 commits into from
Sep 23, 2024
Merged

POTEL 48 - Cleanup POTel TODOs #3705

merged 12 commits into from
Sep 23, 2024

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

Some of the TODOs have been moved to #3436 others are already outdated.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d1d022b

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 431.24 ms 462.68 ms 31.44 ms
Size 1.70 MiB 2.35 MiB 667.17 KiB

Previous results on branch: feat/cleanup-potel-todos

Startup times

Revision Plain With Sentry Diff
4213f52 408.61 ms 412.15 ms 3.54 ms

App size

Revision Plain With Sentry Diff
4213f52 1.70 MiB 2.35 MiB 667.18 KiB

lbloder
lbloder reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the TODO in SpanContext.getOperation also be removed? This should be handled by the OtelSpanContext, correct?

Base automatically changed from feat/respect-ignored-span-types-in-start-child to 8.x.x September 23, 2024 12:41
An error occurred while trying to automatically change base from feat/respect-ignored-span-types-in-start-child to 8.x.x September 23, 2024 12:41
@adinauer adinauer merged commit 6926168 into 8.x.x Sep 23, 2024
11 of 21 checks passed
@adinauer adinauer deleted the feat/cleanup-potel-todos branch September 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @lbloder