Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LazyEvaluator for SpanId creation #3685

Closed
wants to merge 6 commits into from
Closed

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Sep 10, 2024

📜 Description

Use LazyEvaluator to generate UUID on demand

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Use LazyEvaluator for SpanId creation ([#3685](https://github.com/getsentry/sentry-java/pull/3685))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 41b96d2

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 407.22 ms 428.44 ms 21.22 ms
Size 1.70 MiB 2.35 MiB 660.92 KiB

@lbloder lbloder changed the base branch from main to 8.x.x October 7, 2024 08:40
@lbloder lbloder changed the base branch from 8.x.x to main October 7, 2024 08:40
@lbloder lbloder changed the base branch from main to 8.x.x October 7, 2024 08:41
@lbloder lbloder changed the base branch from 8.x.x to main October 7, 2024 08:41
@lbloder
Copy link
Collaborator Author

lbloder commented Oct 7, 2024

Closed in favor of #3770

@lbloder lbloder closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants