-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for opting out of pretty print #2871
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c03a05e | 390.40 ms | 419.35 ms | 28.94 ms |
4c237f8 | 319.84 ms | 354.47 ms | 34.63 ms |
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
0310da5 | 381.20 ms | 404.50 ms | 23.30 ms |
496bdfd | 301.22 ms | 343.96 ms | 42.73 ms |
caf50ec | 302.36 ms | 325.25 ms | 22.89 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
fe10f05 | 294.30 ms | 346.84 ms | 52.54 ms |
adf8fe3 | 300.49 ms | 357.36 ms | 56.87 ms |
fe10f05 | 314.71 ms | 360.62 ms | 45.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c03a05e | 1.72 MiB | 2.29 MiB | 574.43 KiB |
4c237f8 | 1.72 MiB | 2.29 MiB | 575.58 KiB |
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
0310da5 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
caf50ec | 1.72 MiB | 2.29 MiB | 575.24 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
adf8fe3 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
=========================================
Coverage 79.61% 79.62%
- Complexity 6038 6043 +5
=========================================
Files 469 469
Lines 23307 23318 +11
Branches 3177 3178 +1
=========================================
+ Hits 18555 18566 +11
Misses 3355 3355
Partials 1397 1397
☔ View full report in Codecov by Sentry. |
@romtsn @markushi @stefanosiano what do you think about the naming? I'd like to decide on a name before going ahead and implementing other forms of configuration for this new property. |
|
Renamed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📜 Description
A new option to disable pretty printing of events in the debug log.
💡 Motivation and Context
In backend applications there's often many errors and transactions as well as other logs making it hard to look at / copy an event. With pretty print disabled an event takes up only a single line and can more easily be copy pasted to another tool for formatting where output doesn't get rotated out etc.
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps