Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampled to Dynamic Sampling Context #2869

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 27, 2023

📜 Description

Add sampled to dynamic sampling context if available.

💡 Motivation and Context

Fixes #2832

💚 How did you test it?

Unit Tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 56a3a3c

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 330.52 ms 378.90 ms 48.38 ms
Size 1.72 MiB 2.29 MiB 575.58 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
87b3774 310.48 ms 362.04 ms 51.56 ms
f60cce2 299.98 ms 351.18 ms 51.20 ms
fe10f05 294.30 ms 346.84 ms 52.54 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
fe10f05 304.13 ms 365.65 ms 61.52 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
3baa73f 267.45 ms 388.30 ms 120.85 ms
f60279b 324.60 ms 345.33 ms 20.73 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
caf50ec 302.36 ms 325.25 ms 22.89 ms

App size

Revision Plain With Sentry Diff
87b3774 1.72 MiB 2.29 MiB 575.54 KiB
f60cce2 1.72 MiB 2.29 MiB 575.54 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
3baa73f 1.72 MiB 2.29 MiB 575.52 KiB
f60279b 1.72 MiB 2.29 MiB 575.23 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
caf50ec 1.72 MiB 2.29 MiB 575.24 KiB

Previous results on branch: feat/always-send-sampled-flag

Startup times

Revision Plain With Sentry Diff
5d16f66 345.65 ms 388.58 ms 42.93 ms

App size

Revision Plain With Sentry Diff
5d16f66 1.72 MiB 2.29 MiB 575.58 KiB

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 95.65% and project coverage change: +0.01% 🎉

Comparison is base (4bf202b) 81.38% compared to head (fae3225) 81.39%.

❗ Current head fae3225 differs from pull request most recent head 56a3a3c. Consider uploading reports for the commit 56a3a3c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2869      +/-   ##
============================================
+ Coverage     81.38%   81.39%   +0.01%     
- Complexity     4645     4652       +7     
============================================
  Files           354      354              
  Lines         17114    17134      +20     
  Branches       2313     2314       +1     
============================================
+ Hits          13928    13947      +19     
- Misses         2236     2237       +1     
  Partials        950      950              
Files Changed Coverage Δ
sentry/src/main/java/io/sentry/TraceContext.java 84.39% <88.88%> (+0.06%) ⬆️
sentry/src/main/java/io/sentry/Baggage.java 89.80% <100.00%> (+0.52%) ⬆️
...ntry/src/main/java/io/sentry/util/StringUtils.java 88.46% <100.00%> (+0.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adinauer adinauer enabled auto-merge (squash) August 2, 2023 14:18
@adinauer adinauer merged commit 4c237f8 into main Aug 2, 2023
18 checks passed
@adinauer adinauer deleted the feat/always-send-sampled-flag branch August 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sampling Decision to Trace Envelope Header
2 participants