impr: Speed up getBinaryImages V2 #4539
+240
−52
Open
Codecov / codecov/project
succeeded
Nov 15, 2024 in 0s
91.559% (-0.001%) compared to 37fd7a2, passed because coverage increased by 0% when compared to adjusted base (91.558%)
View this Pull Request on Codecov
91.559% (-0.001%) compared to 37fd7a2, passed because coverage increased by 0% when compared to adjusted base (91.558%)
Details
Codecov Report
Attention: Patch coverage is 96.47059% with 6 lines in your changes missing coverage. Please review.
Project coverage is 91.559%. Comparing base (
37fd7a2) to head (d79d53c).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| SentryTestUtils/TestDebugImageProvider.swift | 72.727% | 6 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## main #4539 +/- ##
=============================================
- Coverage 91.560% 91.559% -0.001%
=============================================
Files 614 614
Lines 69777 69923 +146
Branches 24880 24976 +96
=============================================
+ Hits 63888 64021 +133
- Misses 5797 5809 +12
- Partials 92 93 +1 | Files with missing lines | Coverage Δ | |
|---|---|---|
| Sources/Sentry/PrivateSentrySDKOnly.mm | 89.285% <100.000%> (+0.166%) |
⬆️ |
| ...es/Sentry/Profiling/SentryProfilerSerialization.mm | 91.538% <100.000%> (+0.065%) |
⬆️ |
| Sources/Sentry/SentryBinaryImageCache.m | 100.000% <100.000%> (ø) |
|
| Sources/Sentry/SentryDebugImageProvider.m | 88.000% <100.000%> (+1.636%) |
⬆️ |
| Sources/Sentry/SentryTracer.m | 97.049% <100.000%> (ø) |
|
| ...SentryProfilerTests/SentryProfileTestFixture.swift | 99.703% <100.000%> (+0.011%) |
⬆️ |
| Tests/SentryTests/PrivateSentrySDKOnlyTests.swift | 99.752% <100.000%> (+0.016%) |
⬆️ |
| ...ests/SentryTests/SentryBinaryImageCacheTests.swift | 100.000% <100.000%> (ø) |
|
| ...ts/SentryCrash/SentryDebugImageProviderTests.swift | 100.000% <100.000%> (ø) |
|
| ...ts/SentryTests/Transaction/SentryTracerTests.swift | 98.466% <100.000%> (+0.002%) |
⬆️ |
| ... and 1 more |
... and 47 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 37fd7a2...d79d53c. Read the comment docs.
Loading