Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use macos-15 for Xcode 16 #4525

Merged
merged 1 commit into from
Nov 12, 2024
Merged

ci: Use macos-15 for Xcode 16 #4525

merged 1 commit into from
Nov 12, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Nov 12, 2024 •
edited
Loading

Xcode 16 is only available on macos-15 and not anymore on macos-14; see actions/runner-images#10703

This fixes random can't find Xcode 16 errors, such as https://github.com/getsentry/sentry-cocoa/actions/runs/11792762676/job/32846958857

Run ./scripts/ci-select-xcode.sh "16.0"
xcode-select: error: invalid developer directory '/Applications/Xcode_16.0.app/Contents/Developer'
Error: Process completed with exit code 1.

#skip-changelog

@philipphofmann
ci: Use macos-15 for Xcode 16
644991f 
Xcode 16 is only available on macos-15 and not anymore on macos-14; see
actions/runner-images#10703
markushi
markushi approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 9d2e3ee into main Nov 12, 2024
16 checks passed
@philipphofmann philipphofmann deleted the ci/macos-15-xcode-16 branch November 12, 2024 07:50
brustolin
brustolin approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

@markushi markushi markushi approved these changes

@armcknight armcknight Awaiting requested review from armcknight armcknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipphofmann @markushi @brustolin