Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Delete unused SentryBeforeEmitMetricCallback #4516

Merged
merged 2 commits into from
Nov 7, 2024
Merged

ref: Delete unused SentryBeforeEmitMetricCallback #4516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4efb78d
chore: Format SRIntegration
philipphofmann Nov 7, 2024
b8b98d7
ref: Delete unused SentryBeforeEmitMetricCallback
philipphofmann Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions Sources/Sentry/Public/SentryDefines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,6 @@ typedef NSNumber *_Nullable (^SentryTracesSamplerCallback)(
*/
typedef void (^SentrySpanCallback)(id<SentrySpan> _Nullable span);

/**
* A callback block which gets called right before a metric is about to be emitted.

* @param key The key of the metric.
* @param tags A dictionary of key-value pairs associated with the metric.
* @return BOOL YES if the metric should be emitted, NO otherwise.
*/
typedef BOOL (^SentryBeforeEmitMetricCallback)(
NSString *_Nonnull key, NSDictionary<NSString *, NSString *> *_Nonnull tags);

/**
* Log level.
*/
Expand Down
6 changes: 4 additions & 2 deletions Sources/Sentry/SentrySessionReplayIntegration.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ @implementation SentrySessionReplayIntegration {
SentryNSNotificationCenterWrapper *_notificationCenter;
SentryOnDemandReplay *_resumeReplayMaker;
id<SentryRateLimits> _rateLimits;
// We need to use this variable to identify whether rate limiting was ever activated for session replay in this session, instead of always looking for the rate status in `SentryRateLimits`
// This is the easiest way to ensure segment 0 will always reach the server, because session replay absolutely needs segment 0 to make replay work.
// We need to use this variable to identify whether rate limiting was ever activated for session
// replay in this session, instead of always looking for the rate status in `SentryRateLimits`
// This is the easiest way to ensure segment 0 will always reach the server, because session
// replay absolutely needs segment 0 to make replay work.
BOOL _rateLimited;
}

Expand Down
Loading