-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Improve frames tracker performance #4469
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
51ffd8c | 1234.40 ms | 1246.22 ms | 11.82 ms |
b15521e | 1224.44 ms | 1251.13 ms | 26.68 ms |
3297d6e | 1195.69 ms | 1212.35 ms | 16.65 ms |
c6773e5 | 1222.48 ms | 1240.02 ms | 17.54 ms |
39a4941 | 1210.69 ms | 1219.83 ms | 9.14 ms |
ecd9ecd | 1241.28 ms | 1260.35 ms | 19.07 ms |
5269d20 | 1230.18 ms | 1252.64 ms | 22.46 ms |
cbf6225 | 1221.73 ms | 1251.20 ms | 29.47 ms |
3de9971 | 1224.38 ms | 1245.33 ms | 20.95 ms |
add9550 | 1221.20 ms | 1250.04 ms | 28.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
51ffd8c | 21.58 KiB | 418.69 KiB | 397.11 KiB |
b15521e | 21.58 KiB | 573.18 KiB | 551.60 KiB |
3297d6e | 21.58 KiB | 418.44 KiB | 396.86 KiB |
c6773e5 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
39a4941 | 22.84 KiB | 402.63 KiB | 379.79 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
5269d20 | 21.58 KiB | 714.41 KiB | 692.83 KiB |
cbf6225 | 20.76 KiB | 425.77 KiB | 405.00 KiB |
3de9971 | 21.58 KiB | 574.17 KiB | 552.59 KiB |
add9550 | 21.58 KiB | 418.37 KiB | 396.79 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
=============================================
- Coverage 91.818% 91.812% -0.007%
=============================================
Files 610 610
Lines 68230 68237 +7
Branches 24493 24504 +11
=============================================
+ Hits 62648 62650 +2
- Misses 5489 5494 +5
Partials 93 93
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
📜 Description
Improves the speed of the frames tracker by not locking it anymore since it always run in the main thread.
💡 Motivation and Context
Close #4466
💚 How did you test it?
Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps