-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Delete old session replay files #4446
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8838e54 | 1234.71 ms | 1246.46 ms | 11.75 ms |
1ac58a6 | 1232.07 ms | 1254.69 ms | 22.63 ms |
0d32275 | 1245.80 ms | 1267.80 ms | 22.00 ms |
42ef6ba | 1191.51 ms | 1214.08 ms | 22.57 ms |
cd3bfeb | 1226.61 ms | 1226.96 ms | 0.35 ms |
10f96ae | 1216.27 ms | 1239.65 ms | 23.38 ms |
c021422 | 1199.15 ms | 1222.20 ms | 23.05 ms |
98a8c16 | 1206.40 ms | 1232.14 ms | 25.74 ms |
706c41f | 1231.00 ms | 1248.52 ms | 17.52 ms |
f25febb | 1238.80 ms | 1245.35 ms | 6.56 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8838e54 | 22.85 KiB | 413.44 KiB | 390.59 KiB |
1ac58a6 | 21.58 KiB | 626.07 KiB | 604.49 KiB |
0d32275 | 22.84 KiB | 403.14 KiB | 380.29 KiB |
42ef6ba | 21.58 KiB | 417.86 KiB | 396.28 KiB |
cd3bfeb | 20.76 KiB | 425.77 KiB | 405.01 KiB |
10f96ae | 21.58 KiB | 682.02 KiB | 660.44 KiB |
c021422 | 20.76 KiB | 435.64 KiB | 414.88 KiB |
98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
706c41f | 21.58 KiB | 699.25 KiB | 677.67 KiB |
f25febb | 21.58 KiB | 414.92 KiB | 393.34 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4446 +/- ##
=============================================
+ Coverage 91.318% 91.372% +0.053%
=============================================
Files 609 610 +1
Lines 49855 49990 +135
Branches 17932 18044 +112
=============================================
+ Hits 45527 45677 +150
+ Misses 4236 4222 -14
+ Partials 92 91 -1
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Philipp Hofmann <[email protected]>
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
It's just a new function to check whether a path points to a directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
📜 Description
Clean up for old session replay files
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps