Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: Send Cocoa SDK features #3948

Merged
merged 7 commits into from
May 8, 2024
Merged

Conversation

philipphofmann
Copy link
Member

📜 Description

Send enabled Cocoa SDK features with the event payload so that we can track their adoption in Looker.

💡 Motivation and Context

See getsentry/team-sdks#83.

💚 How did you test it?

Unit tests and sending an event via a simulator.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Send enabled SDK features with the event payload, so we can track their
adoption in Looker.
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.795%. Comparing base (7bdf989) to head (4c15f4b).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3948       +/-   ##
=============================================
- Coverage   90.806%   90.795%   -0.011%     
=============================================
  Files          588       590        +2     
  Lines        45879     45945       +66     
  Branches     16370     16378        +8     
=============================================
+ Hits         41661     41716       +55     
+ Misses        4148      4049       -99     
- Partials        70       180      +110     
Files Coverage Δ
Sources/Sentry/SentryClient.m 95.971% <100.000%> (+0.028%) ⬆️
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <100.000%> (ø)
...sts/Helper/SentryEnabledFeaturesBuilderTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/SentryClientTests.swift 97.354% <100.000%> (+0.014%) ⬆️

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bdf989...4c15f4b. Read the comment docs.

@philipphofmann philipphofmann merged commit 1267cb0 into main May 8, 2024
68 of 70 checks passed
@philipphofmann philipphofmann deleted the feat/send-enabled-features branch May 8, 2024 09:32
philipphofmann added a commit that referenced this pull request May 10, 2024
Send enabled SDK features with the event payload, so we can track their
adoption in Looker.
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Send enabled SDK features with the event payload, so we can track their
adoption in Looker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants