-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr: Send Cocoa SDK features #3948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send enabled SDK features with the event payload, so we can track their adoption in Looker.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3948 +/- ##
=============================================
- Coverage 90.806% 90.795% -0.011%
=============================================
Files 588 590 +2
Lines 45879 45945 +66
Branches 16370 16378 +8
=============================================
+ Hits 41661 41716 +55
+ Misses 4148 4049 -99
- Partials 70 180 +110
... and 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
approved these changes
May 7, 2024
philipphofmann
added a commit
that referenced
this pull request
May 10, 2024
Send enabled SDK features with the event payload, so we can track their adoption in Looker.
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
Send enabled SDK features with the event payload, so we can track their adoption in Looker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Send enabled Cocoa SDK features with the event payload so that we can track their adoption in Looker.
💡 Motivation and Context
See getsentry/team-sdks#83.
💚 How did you test it?
Unit tests and sending an event via a simulator.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps