Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Session Replay): Replay Options #3674

Merged
merged 39 commits into from
Feb 29, 2024

Conversation

brustolin
Copy link
Contributor

Settings for session replay in the Options.

#skip-changelog

Copy link

github-actions bot commented Feb 21, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 55a6a5d

Copy link

github-actions bot commented Feb 21, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.33 ms 1229.04 ms 17.71 ms
Size 21.58 KiB 430.62 KiB 409.04 KiB

Previous results on branch: feat(SR)/replay-settings

Startup times

Revision Plain With Sentry Diff
5583f7d 1226.60 ms 1248.15 ms 21.54 ms
fdb13d4 1203.73 ms 1211.39 ms 7.66 ms
f5fef43 1207.51 ms 1213.69 ms 6.18 ms

App size

Revision Plain With Sentry Diff
5583f7d 21.58 KiB 430.59 KiB 409.01 KiB
fdb13d4 21.58 KiB 430.70 KiB 409.12 KiB
f5fef43 21.58 KiB 425.58 KiB 403.99 KiB

@brustolin brustolin changed the title Feat(Session Replay): Replay Settings Feat(Session Replay): Replay Options Feb 22, 2024
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this refactoring into an extra PR.

Base automatically changed from feat(SR)/ReplayEvent to feat/session-replay February 29, 2024 09:26
@brustolin brustolin merged commit 2c6fff0 into feat/session-replay Feb 29, 2024
68 checks passed
@brustolin brustolin deleted the feat(SR)/replay-settings branch February 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants